On 11/11/19 9:38 AM, Daniel P. Berrangé wrote: > As part of an goal to eliminate Perl from libvirt build tools, > rewrite the check-aclperms.pl tool in Python. > > This was a straight conversion, manually going line-by-line to > change the syntax from Perl to Python. Thus the overall structure > of the file and approach is the same. > > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> > --- > Makefile.am | 1 + > scripts/check-aclperms.py | 75 +++++++++++++++++++++++++++++++++++++++ > src/Makefile.am | 4 +-- > src/check-aclperms.pl | 73 ------------------------------------- > 4 files changed, 78 insertions(+), 75 deletions(-) > create mode 100755 scripts/check-aclperms.py > delete mode 100755 src/check-aclperms.pl I verified changing the name of a string permission in viraccessperm.c triggers the first error. not sure if the second one at the end of the file is even triggerable due to compile time protections, but it's still safe to have Tested-by: Cole Robinson <crobinso@xxxxxxxxxx> - Cole -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
