On Thu, Nov 14, 2019 at 04:57:49PM -0500, Cole Robinson wrote: > On 10/22/19 11:47 AM, Stefano Garzarella wrote: > > ruby_libvirt_value_to_int() returns 0 if the optional value is > > not defined, but in node_cpu_stats() and node_memory_stats() > > the default value of cpuNum and cellNum is -1. > > > > I know nothing about ruby or the libvirt bindings, but what you describe > makes sense and matches my reading of the code. -1 is > VIR_NODE_CPU_STATS_ALL_CPUS and VIR_NODE_MEMORY_STATS_ALL_CELLS so it > makes sense that would be the default. > > Reviewed-by: Cole Robinson <crobinso@xxxxxxxxxx> Thank you for reviewing it! Charlie found this issue some weeks ago and I tried to fix it, but I don't have much experience with ruby. > > CCing clalance who is the primary ruby-libvirt maintainer, but if he > doesn't get to it by next week then I'll figure out how to build test > it, and push Thanks, Stefano -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
