Re: [PATCH 1/2] util: use g_vsnprintf

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 13, 2019 at 10:33:08 +0100, Ján Tomko wrote:
> Instead of vsnprintf from gnulib, use g_vsnprintf from GLib.
> 
> Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx>
> ---
>  src/util/virerror.c      | 4 ++--
>  src/util/virtypedparam.c | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

I think you should add a syntax-check rule forbidding use of plain
vsnprintf.

With that:

Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>

I queued the appropriate patch to bootstrap.conf to my branch of the
kill-a-gnulib-module-a-day initiative.

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux