On Tue, Nov 12, 2019 at 04:10:19PM +0100, Erik Skultety wrote:
> Presumably, the original intent of the code was to query the status of
> the service to refresh the internal state variable, but the intended
> method was never called because of a typo.
> ---
> lib/Sys/Virt/TCK/Hooks.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/Sys/Virt/TCK/Hooks.pm b/lib/Sys/Virt/TCK/Hooks.pm
> index ef3403d..a3615e4 100644
> --- a/lib/Sys/Virt/TCK/Hooks.pm
> +++ b/lib/Sys/Virt/TCK/Hooks.pm
> @@ -263,7 +263,7 @@ sub service_libvirtd {
>
> die "failed on $action daemon" if system $cmd;
>
> - $self->libvirtd_status;
> + $self->libvirtd_status();
There's no need for () when invoking a method if it doesn't need any
parameters. Actually even if it does need parameters there's some
silly ways you can invoke it without round brackets. Welcome to the
wonderful world of perl :-)
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
