On Mon, Nov 11, 2019 at 09:35:31PM +0100, Jiri Denemark wrote: > The pconfig feature was enabled in QEMU by accident in 3.1.0. All other > newer versions do not support it and it was removed from the > Icelake-Server CPU model in QEMU. > > We don't normally change our CPU models even when QEMU does so to avoid > breaking migrations between different versions of libvirt. But we can > safely do so in this specific case. QEMU never supported enabling > pconfig so any domain which was able to start has pconfig disabled. > > With a small compatibility hack which explicitly disables pconfig when > CPU model equals Icelake-Server in migratable domain definition, only > one migration scenario stays broken (and there's nothing we can do about > it): from any host to a host with libvirt < 5.10.0 and QEMU > 3.1.0. > > https://bugzilla.redhat.com/show_bug.cgi?id=1749672 > > Jiri Denemark (6): > cpu_conf: Pass policy to CPU feature filtering callbacks > qemuxml2*test: Add tests for Icelake-Server,-pconfig > qemu: Drop disabled CPU features unknown to QEMU > cpu_map: Drop comments about ospke > cputest: Add data for Ice Lake Server CPU > cpu_map: Drop pconfig from Icelake-Server CPU model Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
