On Fri, 2019-11-08 at 13:16 +0300, Vladimir Sementsov-Ogievskiy wrote: > v2: > Don't deprecate drive-backup, it is unrelated thing and will be resent > in separate. > Don't deprecate drive-mirror. Instead add filter-node-name to > drive-mirror to behave like blockdev-mirror > Fix all broken iotests. I did a quick overview of these patches (I don't know the area well to do a full review) and it looks fine to me, other than that FIXME you added, which (at least looking at the explanation) I think should be investigated, as it might point to a deeper problem somewhere. Also *I think* that I would merge these two patches together, but this is only my personal taste. Best regards, Maxim Levitsky > > Vladimir Sementsov-Ogievskiy (2): > qapi: add filter-node-name option to drive-mirror > qapi: deprecate implicit filters > > qemu-deprecated.texi | 6 ++++++ > qapi/block-core.json | 14 ++++++++++++-- > include/block/block_int.h | 10 +++++++++- > blockdev.c | 12 +++++++++++- > tests/qemu-iotests/094 | 1 + > tests/qemu-iotests/095 | 6 ++++-- > tests/qemu-iotests/109 | 1 + > tests/qemu-iotests/127 | 1 + > tests/qemu-iotests/141 | 5 ++++- > tests/qemu-iotests/144 | 3 ++- > tests/qemu-iotests/156 | 1 + > tests/qemu-iotests/161 | 7 +++++++ > tests/qemu-iotests/161.out | 1 + > tests/qemu-iotests/185 | 3 +++ > tests/qemu-iotests/191 | 2 ++ > tests/qemu-iotests/229 | 1 + > tests/qemu-iotests/247 | 8 +++++--- > tests/qemu-iotests/249 | 5 +++-- > tests/qemu-iotests/249.out | 2 +- > 19 files changed, 75 insertions(+), 14 deletions(-) > -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
