[PATCH 7/8] tests: Add return value check in checkUserInfo

[John Ferlan <jferlan@xxxxxxxxxx>]

Commit 1c8113f9c added the call to virTypedParamsGetString without
a return value check which caused Coverity to complain especially
since other checks for the same function are made.

Found by Coverity

Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
---
 tests/qemuagenttest.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/qemuagenttest.c b/tests/qemuagenttest.c
index cef9ae5fee..ae55086d17 100644
--- a/tests/qemuagenttest.c
+++ b/tests/qemuagenttest.c
@@ -1127,7 +1127,9 @@ checkUserInfo(virTypedParameterPtr params,
 
     snprintf(param_name, VIR_TYPED_PARAM_FIELD_LENGTH,
              "user.%zu.domain", nth);
-    virTypedParamsGetString(params, nparams, param_name, &domain);
+    if (virTypedParamsGetString(params, nparams, param_name, &domain) < 0)
+        return -1;
+
     if (STRNEQ_NULLABLE(expDomain, domain)) {
         virReportError(VIR_ERR_INTERNAL_ERROR,
                        "Expected domain '%s', got '%s'",
-- 
2.20.1

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list