On 01/11/19 06:40, Markus Armbruster wrote: > Paolo Bonzini <pbonzini@xxxxxxxxxx> writes: > >> On 31/10/19 11:58, John Snow wrote: >>> It's an old compatibility shim that just delegates to ide-cd or ide-hd. >>> I'd like to refactor these some day, and getting rid of the super-object >>> will make that easier. >>> >>> Either way, we don't need this. >> >> Good idea. I will prepare a similar patch for scsi-disk, even though >> technically we're already in soft freeze; it makes no sense to deprecate >> only one of the two. > > We still use scsi-disk for -drive if=scsi,... and for the desugaring of > the usb-storage device, via scsi_bus_legacy_add_drive(). I figure you'd > need to either wean them off scsi-disk or deprecate them, too. Yes, it's enough to add a bool media_cdrom argument to scsi_bus_legacy_add_drive. Paolo -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
