Re: [PATCH 39/75] conf: Use g_strdup_printf() instead of virAsprintf()

[Eric Blake <eblake@xxxxxxxxxx>]

On 10/22/19 8:57 AM, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---

> +++ b/src/conf/domain_audit.c

> @@ -373,15 +373,15 @@ virDomainAuditHostdev(virDomainObjPtr vm, virDomainHostdevDefPtr hostdev,
>       case VIR_DOMAIN_HOSTDEV_MODE_SUBSYS:
>           switch ((virDomainHostdevSubsysType) hostdev->source.subsys.type) {
>           case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI:
> -            virAsprintf(&address,
> -                        VIR_PCI_DEVICE_ADDRESS_FMT,
> -                        pcisrc->addr.domain,
> -                        pcisrc->addr.bus,
> -                        pcisrc->addr.slot,
> -                        pcisrc->addr.function);
> +            address = g_strdup_printf(
> +                                      VIR_PCI_DEVICE_ADDRESS_FMT,

This should be one line, not two.

> +                                      pcisrc->addr.domain,
> +                                      pcisrc->addr.bus,
> +                                      pcisrc->addr.slot,
> +                                      pcisrc->addr.function);
>               break;
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list