Re: [PATCH] m4: Improve portability for non-bash shells

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2019-10-19 at 11:46 +0000, Maya Rashish wrote:
> = and == are both operators to test for string equality in bash,
> but only = is required by POSIX.
> 
> Signed-off-by: Maya Rashish <coypu@xxxxxxx>
> ---
>  m4/virt-nls.m4 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Welp, I'm surprised nobody noticed until now: the code in question
has been merged more than a year ago.

Anyway, your fix is correct, so

  Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

and pushed.

Congratulation on your first libvirt contribution! :)

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux