On 10/19/19 5:55 PM, Ján Tomko wrote:
On Sat, Oct 19, 2019 at 07:21:15AM -0300, Daniel Henrique Barboza wrote:
On 10/18/19 7:37 PM, Ján Tomko wrote:
Ján Tomko (10):
tools: cmdDomblkinfoGet: reindent parameters
virsh: use g_strdup in cmdDomblkinfoGet
virsh: use g_strdup in virshDomainGetEditMetadata
virsh: getSignalNumber: rename variables
virsh: getSignalNumber: use g_autofree
virsh: getSignalNumber: use g_strdup
tools: vshCommandArgvGetArg: one parameter per line
tools: vshCommandArgvGetArg: prefer g_strdup
tools: prefer g_strdup to vshStrdup
tools: delete vshStrdup
All patches:
Reviewed-by: Daniel Henrique Barboza <danielhb413@xxxxxxxxx>
Question: I see that you're pushing the glib chronicles recently. Do
you have plans to do the virAsprintf -> g_strdup_printf conversion?
I am asking because I started this conversion yesterday, and the
amount of calls to be converted is so massive that it's kind of funny.
And it's not a work that I'll be able to full commit during the workday
mprivozn started working on that on Friday using Coccinelle, you need to
ask him. Chances are you already converted some usage that was not
simply caught by his spatch.
Indeed, I just can't decide whether to drop all checks related to
virAsprintf() first and only after that do transition to
g_strdup_printf() or do the transition first and then drop all checks
related (since the glib function can't fail).
https://travis-ci.org/zippy2/libvirt/builds/600171599
https://travis-ci.org/zippy2/libvirt/builds/600597977
I will need to rebase both branches when Jano pushes his VIR_STRDUP
branch though.
Michal
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
