I already had some of these changes locally from my review, so I decided to
send a quick cleanup series on the x and y resolution changes myself.
The last patch in the series is a similar cleanup to a related function that
was probably the inspiration for the resolution parsing function. It
changes the behavior of this function slightly, but I think the previous
behavior should be considered a bug.
An illustration of the change in behavior: previously, the following
configuration (note: invalid value for accel2d):
<acceleration accel2d='foo' accel3d='yes' rendernode='/dev/dri/test'/>
would have resulted in the the parse function returning the following struct:
{
accel2d = 0; /* default value */
accel3d = 1; /* YES */
rendernode = NULL /* default value - not parsed due to accel2d error */
}
After this patch, the parse function returns NULL instead. I think that's an
improvement, but it is different than the previous behavior.
Jonathon Jongsma (5):
qemu: fix documentation for video resolution
conf: Return error when resolution values are invalid
conf: remove unnecessary NULL checks
conf: ensure both resolution values are non-zero
conf: report errors when parsing video accel
docs/formatdomain.html.in | 12 ++++++----
src/conf/domain_conf.c | 46 +++++++++++++++++++--------------------
2 files changed, 30 insertions(+), 28 deletions(-)
--
2.21.0
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
