On 9/26/19 12:12 PM, Michal Privoznik wrote: > Since its introduction in v1.0.5-rc1-19-g6e13860cb4 the > qemuTeardownHostdevCgroup() does nothing unless the passed > hostdev is a PCI device with VFIO backend. This seems > unnecessary. > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > src/qemu/qemu_cgroup.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c > index 318157dab0..4d6f0c33cd 100644 > --- a/src/qemu/qemu_cgroup.c > +++ b/src/qemu/qemu_cgroup.c > @@ -405,16 +405,10 @@ qemuTeardownHostdevCgroup(virDomainObjPtr vm, > size_t i, npaths = 0; > int rv, ret = -1; > > - /* currently this only does something for PCI devices using vfio > - * for device assignment, but it is called for *all* hostdev > - * devices. > - */ > - > if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES)) > return 0; > > - if (virHostdevIsVFIODevice(dev) && > - qemuDomainGetHostdevPath(vm->def, dev, true, > + if (qemuDomainGetHostdevPath(vm->def, dev, true, > &npaths, &path, NULL) < 0) > goto cleanup; > > Agreed, seems sensible to reflect qemuSetupHostdevCgroup Reviewed-by: Cole Robinson <crobinso@xxxxxxxxxx> - Cole -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
