Re: [PATCH v4 0/5] qemu_driver: GLib powered cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/16/19 10:54 PM, Daniel Henrique Barboza wrote:
changes from v3:
- only use the new Glib macros in all patches
- different patch split, as suggested by Jano in v3 review
- patch 5 (new): g_strdup_printf conversion

changes from v2:
- rebased with newer master (67e72053c1)
- added an extra patch to convert the existing VIR_AUTO* macros
to g_auto* ones, all at once, to avoid the case where a method
will have both VIR_AUTO* and g_auto* macros at the same time.

changes from v1:
- addressed review concerns made by Erik
- added more cleanups, as suggested by Erik

v3: https://www.redhat.com/archives/libvir-list/2019-October/msg00918.html
v2: https://www.redhat.com/archives/libvir-list/2019-September/msg01452.html
v1: https://www.redhat.com/archives/libvir-list/2019-September/msg00719.html

Daniel Henrique Barboza (5):
   qemu_driver: use g_auto* in some functions
   qemu_driver: use g_autoptr() when possible
   qemu_driver: use g_autofree when possible
   qemu_driver: remove unused 'cleanup' labels after g_auto*() changes
   qemu_driver: use g_strdup_printf

  src/qemu/qemu_driver.c | 721 ++++++++++++++---------------------------
  1 file changed, 242 insertions(+), 479 deletions(-)



I'll replace qemu_driver with qemu_driver.c in subjects because you're touching qemu_driver.c only.

Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

And pushed.

Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux