Re: [PATCH] build: Update .gitignore for build-aux files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 16, 2019 at 10:10:48AM -0500, Eric Blake wrote:
> On 10/16/19 9:23 AM, Daniel P. Berrangé wrote:
> > On Wed, Oct 16, 2019 at 10:17:16AM -0400, John Ferlan wrote:
> > > 
> > > 
> > > On 10/16/19 10:08 AM, Daniel P. Berrangé wrote:
> > > > On Wed, Oct 16, 2019 at 08:54:26AM -0400, John Ferlan wrote:
> > > > > Recent changes moved some files to build-aux and created at least
> > > > > one more.
> > > > 
> > > > Really ? I wasn't aware that we'd moved the files listed in
> > > > this change.
> > > > 
> > > 
> > > Well that's where they now show up... I dunno. I had to clean my
> > > environment more than once due to recent changes and these files now
> > > show up in the noted/changed locations.  I also use a clean environment
> > > for my coverity builds every day and this is where they show up.
> > 
> > Oh in fact I see them in the same place build-aux, but git is not
> > reporting them despite not being listed in gitignore.
> > 
> > I wonder if it has some default ignore list its using ?
> 
> When using gnulib's bootstrap, gnulib creates or augments .gitignore as
> needed to cover files that it copies in or which autoconf/automake will
> install.  But as we have been moving away from that, we have to pick up the
> slack and ignore the files ourselves.

I think we're fine to continue relyuing on bootstrap to create this
.gitignore file until we switch to meson, at which point it won't
matter anyway, as we'll isolate everything gnulib does in its own
subdirectory away from the root.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux