On Thu, Dec 10, 2009 at 01:41:39PM +0000, Matthew Booth wrote: > This change makes the QEMU driver get pty paths from the output of the monitor > 'info chardev' command. This output is structured, and contains both the name of > the device and the path on the same line. This is considerably more reliable > than parsing the startup log output, which requires the parsing code to know > which order QEMU will print pty information in. > > Note that we still need to parse the log output as the monitor itself may be on > a pty. This should be rare, however, and the new code will replace all pty paths > parsed by the log output method once the monitor is available. > > * src/qemu/qemu_monitor.(c|h) src/qemu_monitor_text.(c|h): Implement > qemuMonitorGetPtyPaths(). > * src/qemu/qemu_driver.c: Get pty path information using > qemuMonitorGetPtyPaths(). Okay, I have pushed the 3 patches, code looks fine, and lot of regression tests ! I just changed that last patch to reformat the macro and replaced a free() into VIR_FREE() ... IIRC those were pointed by danpb in his last review. thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list