Re: [jenkins-ci PATCH v2 12/12] Switch libvirt-dbus to Meson

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2019-10-08 at 09:58 +0200, Fabiano Fidêncio wrote:
> +++ b/guests/playbooks/build/projects/libvirt-dbus.yml
>    vars:
>      # flake8 and pyflakes versions available on FreeBSD (3.5.0 and 2.0.0
> -    # respectively) are not compatible
> +    # respectively) are not compatible.
> +    # Python3 version in Ubuntu 16.04 and python3-pytest version
> +    # in CentOS 7 are too old

[...]

> +++ b/jenkins/projects/libvirt-dbus.yaml
> @@ -6,30 +6,24 @@
> +      - meson-check-job:
>            parent_jobs: 'libvirt-dbus-build'
>            # flake8 and pyflakes versions currently available on FreeBSD
>            # (3.5.0 and 2.0.0 respectively) are not compatible.
> +          # pytest version is CentOS 7 is too old.

Make sure the comments match.

With that fixed, and with the obvious caveat that we'll have to
coordinate with Pavel so that this is merged at the same time as the
libvirt-dbus patches,

  Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux