Re: [PATCH v2 07/23] src: add support for g_autoptr with virObject instances

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 07, 2019 at 06:14:09PM +0100, Daniel P. Berrangé wrote:
Libvirt currently uses the VIR_AUTOUNREF macro for auto cleanup of
virObject instances. GLib approaches things differently with GObject,
reusing their g_autoptr() concept.

This introduces support for g_autoptr() with virObject, to facilitate
the conversion to GObject.

Only virObject classes which are currently used with VIR_AUTOREF are
updated. Any others should be converted to GObject before introducing
use of autocleanup.

Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
---
docs/hacking.html.in            |  5 +++++
src/conf/capabilities.h         |  3 +++
src/conf/domain_capabilities.h  |  3 +++
src/conf/domain_conf.h          |  3 +++
src/conf/snapshot_conf.h        |  3 +++
src/conf/storage_capabilities.h |  3 +++
src/datatypes.h                 | 15 +++++++++++++++
src/libxl/libxl_conf.h          |  2 ++
src/qemu/qemu_blockjob.h        |  1 +
src/qemu/qemu_capabilities.h    |  2 ++
src/qemu/qemu_conf.h            |  3 +++
src/util/virhostdev.h           |  3 +++
src/util/viridentity.h          |  2 ++
src/util/virmdev.h              |  3 +++
src/util/virobject.h            |  4 ++++
src/util/virpci.h               |  3 +++
src/util/virresctrl.h           |  4 ++++
src/util/virscsi.h              |  3 +++
src/util/virscsivhost.h         |  3 +++
src/util/virstoragefile.h       |  2 ++
src/util/virusb.h               |  3 +++
21 files changed, 73 insertions(+)


Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux