Re: [PATCH] build: force -Werror for distcheck target

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 7, 2019 at 4:16 PM Daniel P. Berrangé <berrange@xxxxxxxxxx> wrote:
>
> The 'make distcheck' target validates that a tarball builds and
> is ready for release. We expect that libvirt builds cleanly on
> all supported platforms, so we should be enabling -Werror when
> running distcheck.
>
> This ensures that our CI systems in turn also use -Werror.
>
> Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> ---
>  Makefile.am | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Makefile.am b/Makefile.am
> index 2cc4b91f9c..1a9f3af66d 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -19,6 +19,10 @@
>  LCOV = lcov
>  GENHTML = genhtml
>
> +# when building from tarball -Werror isn't auto enabled
> +# so force it explicitly
> +DISTCHECK_CONFIGURE_FLAGS = --enable-werror
> +
>  SUBDIRS = . gnulib/lib include/libvirt src tools docs gnulib/tests \
>    tests po examples
>
> --
> 2.21.0
>
> --
> libvir-list mailing list
> libvir-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/libvir-list

Reviewed-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx>

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux