On Thu, Oct 03, 2019 at 05:34:50PM +0200, Ján Tomko wrote: > On Thu, Oct 03, 2019 at 02:53:14PM +0100, Daniel P. Berrangé wrote: > > The usleep function was missing on older mingw versions, but we can rely > > on it existing everywhere these days. > > > > Per https://www.gnu.org/software/gnulib/manual/html_node/usleep.html#usleep > usleep only works up to one second on mingw. > > However from 'git grep usleep' it seems that the virsh usage is the only > one possibly relevant to Windows. Doh, I totally misread that note. > Is there any benefit of using usleep for values that are multiples of > 1000? Just nice to have consistency. I'll move this patch into my glib series, as I can do a straight s/usleep/g_usleep/, as that calls to Sleep() on Win32 to avoid the problem, albeit with only millisecond precision but that's fine. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
