On Tue, 2019-10-01 at 16:28 +0200, Fabiano Fidêncio wrote:
> As now we've the needed packages for building and testing libosinfo
> on all systems supported by libvirt-jenkins-ci, let's just build
> libosinfo everywhere.
>
> RPM build is still not possible in CentOS7 as it doesn't have the
> needed RPM macros for Meson.
>
> Signed-off-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx>
> ---
> guests/host_vars/libvirt-centos-7/main.yml | 1 +
> guests/host_vars/libvirt-debian-9/main.yml | 1 +
> guests/host_vars/libvirt-ubuntu-16/main.yml | 1 +
> guests/host_vars/libvirt-ubuntu-18/main.yml | 1 +
> guests/playbooks/build/projects/libosinfo.yml | 12 +-----------
> jenkins/projects/libosinfo.yaml | 8 +-------
> 6 files changed, 6 insertions(+), 18 deletions(-)
The same comments about merge conflicts and lack of comments made
for the previous patch apply to this one as well.
Additionally, the order in which you're restoring these jobs is
arguably wrong: it should be osinfo-db-tools, osinfo-db and then
libosinfo, not osinfo-db-tools, libosinfo and then osinfo-db. Easy
enough to shuffle them around :)
> +++ b/jenkins/projects/libosinfo.yaml
> @@ -3,13 +3,7 @@
> name: libosinfo
> # libosinfo depends on meson 0.49.0, which is not available on
> # CentOS 7, Debian 9, Ubuntu 18;
> - machines:
> - - libvirt-debian-10
> - - libvirt-fedora-29
> - - libvirt-fedora-30
> - - libvirt-fedora-rawhide
> - - libvirt-freebsd-11
> - - libvirt-freebsd-12
> + machines: '{{ all_machines }}'
You forgot to remove the comment here, and also once again got the
Jenkins syntax wrong.
With the issues highlighted above fixed,
Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
