On Tue, 2019-10-01 at 16:28 +0200, Fabiano Fidêncio wrote:
> As now we've the needed packages for building and testing
> osinfo-db-tools on all systems supported by libvirt-jenkins-ci, let's
> just build osinfo-db-tools everywhere.
>
> RPM build is still not possible in CentOS7 as it doesn't have the
> needed RPM macros for Meson.
I think it would be a good idea to document this fact right in the
corresponding file with a comment, same as we've done with other
cases where we had to exclude a specific target platform from a
build job for one reason or another.
> +++ b/guests/host_vars/libvirt-centos-7/main.yml
> @@ -8,6 +8,7 @@ projects:
> - libvirt-perl
> - libvirt-python
> - osinfo-db
> + - osinfo-db-tools
> - virt-viewer
This (and the similar changes made to other files) will conflict with
recent fixes I've pushed, but addressing that is trivial.
> +++ b/jenkins/projects/osinfo-db-tools.yaml
> @@ -1,15 +1,7 @@
> ---
> - project:
> name: osinfo-db-tools
> - # osinfo-db-tools requires meson 0.49.0, which is not available on
> - # CentOS 7 and Debian 9;
> - machines:
> - - libvirt-debian-10
> - - libvirt-fedora-29
> - - libvirt-fedora-30
> - - libvirt-fedora-rawhide
> - - libvirt-freebsd-11
> - - libvirt-freebsd-12
> + machines: '{{ all_machines }}'
For the Jenkins part you need to use
machines: '{all_machines}'
or it won't work.
With that fixed and a comment about RPM macros added,
Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
