On Thu, Sep 19, 2019 at 16:24:51 -0400, Collin Walling wrote: > Note: since I've made some changes to a lot of these patches / split > up some patches, I've decided to hold off on adding any r-b's in case > there is a specific change that someone does not agree with. > > Changelog: > > - Properly refactored code from CPU model expansion function > - Introduced a cleanup patch for CPU model expansion function > - Introduced patches that modifies the refactored code to suit > needs for baseline/comparison > - CPU expansion function now accepts a virCPUDefPtr > - Removed props parsing from CPU model comparison (they weren't > used) > - Cleaner error reporting when baselining/comparing with erroneous > CPU models / features > - Various cleanups based on feedback Thanks. All but 15/15 are acked now and I will push them as soon as we leave the pre-release freeze period. The patch 15/15 needs a little bit of tweaking, but it is not essential and it can be pushed later as a follow-up patch. Alternatively, if you want to work on it while we are frozen, you can use the s390-cpu-apis branch (based on current master) of my staging repo https://gitlab.com/jirkade/libvirt.git Jirka -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list