On Mon, Sep 30, 2019 at 03:41:00PM +0200, Pavel Mores wrote: > The way in which the qemu driver generates aliases for disks involves > ignoring the partition number part of a target dev name. This means that > all partitions of a block device and the device itself all end up with the > same alias. If multiple such disks are specified in XML, the resulting > name clash makes qemu invocation fail. > > Since attaching partitions to qemu VMs doesn't seem to make much sense > anyway, disallow partitions in target specifications altogether. > > https://bugzilla.redhat.com/show_bug.cgi?id=1346265 > > Signed-off-by: Pavel Mores <pmores@xxxxxxxxxx> > --- > src/qemu/qemu_domain.c | 15 +++++++++++ > .../disk-attaching-partition-nosupport.xml | 27 +++++++++++++++++++ > tests/qemuxml2argvtest.c | 1 + > 3 files changed, 43 insertions(+) > create mode 100644 tests/qemuxml2argvdata/disk-attaching-partition-nosupport.xml Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
