Re: [PATCH] docs: document that C & Python are the preferred languages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 30, 2019 at 08:50:51PM +0000, Jim Fehlig wrote:
> On 9/23/19 7:52 AM, Daniel P. Berrangé  wrote:
> > On Thu, Sep 05, 2019 at 06:15:04PM +0100, Daniel P. Berrangé wrote:
> >> On Thu, Sep 05, 2019 at 12:30:27PM -0400, Laine Stump wrote:
> >>> (BTW, what does the removal of perl from libvirt say about continued
> >>> use of perl for libvirt-tck? There are a lot of useful tests in there
> >>> that find real bugs, but they tend to languish (both in use and in
> >>> enhancements) because nobody wants to do anything with perl (or with
> >>> the big shell scripts that do the nwfilter testing). It would be nice
> >>> if the tests were all in a language that was more accessible, but
> >>> they're kind of married to the perl TAP module (and besides, who
> >>> wants to spend time rewriting a bunch of test scripts when they
> >>> already work?). This is mostly a moot point, because I think hardly
> >>> anyone runs the libvirt-tck tests anymore, which is too bad because
> >>> it has historically caught some regressions that no other testing
> >>> framework did.)
> >>
> >> I believe they are run by the Red Hat virt QE team, as I ave
> >> got bug reports against the Perl libvirt bindings, where the
> >> reproducer is a TCK script.
> 
> Sorry for jumping in late, but I also run TCK regularly and agree that it does 
> find real bugs on occasion. I've submitted several patches over the years fixing 
> bugs found by TCK, and a sprinkling of patches to TCK itself. I admit the perl 
> requirement has deterred writing new tests.

Thanks for the feedback. To summarize my thoughts on what we do with
the TCK:

 - Replace the test execution harness with tappy, which is a python
   impl that can consume TAP format
 - Add supporting code to facilitate writing new scripts in python
 - New tests should then be written in Python
 - Existing tests can remain in Perl indefinitely
 - Existing Perl tests can be ported to Python as desired.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux