Re: [PATCH] qemu_capabilities: Put only unique FW images into domcaps

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2019-09-12 at 15:31 +0200, Michal Privoznik wrote:
> In the domain capabilities XML there are FW image paths printed.
> There are two sources for the image paths (in order of
> preference):
> 
>   1) firmware descriptor files - as returned by
>   qemuFirmwareGetSupported()
> 
>   2) a compile time list of FW:NRAM pairs which can be overridden
>   in qemu.conf
> 
> If either of those contains a duplicate FW image path (which is
> a valid use case) it is printed twice in the capabilities XML.
> While it's technically not a bug, it doesn't look good.
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  src/qemu/qemu_capabilities.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)

Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux