Re: [PATCH 0/8] qemu: Lock-out checkpoints until backups are ready

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/26/19 10:51 AM, Peter Krempa wrote:
See patch 6/8 for the reasoning.

This series applies on top of the v2 of splitting checkpoints into a
separate file.

Peter Krempa (8):
   qemu: checkpoint: Refactor cleanup in qemuCheckpointCreateXML
   qemu: checkpoint: Remove open-ended TODOs
   qemu: Simplify argument list of qemuDomainBlockPullCommon
   qemu: Don't repeat virDomainObjEndAPI in qemuDomainBlockPull
   qemu: caps: Add capability for incremental backup support
   qemu: checkpoint: Forbid creating checkpoints until we support backups
   qemu: Aggregate interlocking of blockjobs by checkpoints in one place
   qemu: domain: Base block job interlocking on
     QEMU_CAPS_INCREMENTAL_BACKUP

Couple of minor comments, but overall the series makes sense (even if it's rough to see a regression in support, I agree with the comment that you can at least override it with custom xml namespace, and we ARE working towards re-enabling things as soon as possible).

Reviewed-by: Eric Blake <eblake@xxxxxxxxxx>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux