25.09.2019 16:01, John Snow wrote: > > > On 9/25/19 3:20 AM, Vladimir Sementsov-Ogievskiy wrote: >> 25.09.2019 2:01, John Snow wrote: >>> This parameter has been deprecated since 2.12.0 and is eligible for >>> removal. Remove this parameter as it is actually completely ignored; >>> let's not give false hope. >>> >>> Signed-off-by: John Snow <jsnow@xxxxxxxxxx> >>> --- >>> qemu-deprecated.texi | 20 +++++++++++++++----- >>> qapi/block-core.json | 6 +----- >>> blockdev.c | 6 ------ >>> 3 files changed, 16 insertions(+), 16 deletions(-) >>> >>> diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi >>> index 01245e0b1c..d60246d5d6 100644 >>> --- a/qemu-deprecated.texi >>> +++ b/qemu-deprecated.texi >>> @@ -149,11 +149,6 @@ QEMU 4.1 has three options, please migrate to one of these three: >>> >>> @section QEMU Machine Protocol (QMP) commands >>> >>> -@subsection block-dirty-bitmap-add "autoload" parameter (since 2.12.0) >>> - >>> -"autoload" parameter is now ignored. All bitmaps are automatically loaded >>> -from qcow2 images. >>> - >>> @subsection query-block result field dirty-bitmaps[i].status (since 4.0) >>> >>> The ``status'' field of the ``BlockDirtyInfo'' structure, returned by >>> @@ -356,3 +351,18 @@ existing CPU models. Management software that needs runnability >>> guarantees must resolve the CPU model aliases using te >>> ``alias-of'' field returned by the ``query-cpu-definitions'' QMP >>> command. >>> + >>> + >>> +@node Recently removed features >>> +@appendix Recently removed features >>> + >>> +What follows is a record of recently removed, formerly deprecated >>> +features that serves as a record for users who have encountered >>> +trouble after a recent upgrade. >>> + >>> +@section QEMU Machine Protocol (QMP) commands >>> + >>> +@subsection block-dirty-bitmap-add "autoload" parameter (since 2.12.0) >> >> Agree with Eric that it should be 4.2 - as this section is about removing >> > > Yes, shame on me. I spent about three seconds on this patch and should > have spent four. > >>> + >>> +"autoload" parameter is now ignored. All bitmaps are automatically loaded >>> +from qcow2 images. >> >> Maybe, rephrase it as s/is now ignored/is now removed (ignored since 2.12.0)/ , >> so that this paragraph don't mislead without a context. >> > > Also a good idea. > > 'The "autoload" parameter has been ignored since 2.12.0. All bitmaps are > automatically loaded from qcow2 images.' OK > >> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@xxxxxxxxxxxxx> >> >> (Yay, deprecation works!) >> > > Thanks, and I'll get to the rest of your pending bitmap patches and > cleanups soon. > That's great! -- Best regards, Vladimir -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
