Re: [PATCH 2/4] qemu: migration: Forbid only remote migration if autodestroy is active for VM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/24/19 8:17 AM, Peter Krempa wrote:
> Semantically we can't guarantee that we'll be able to destroy the VM on
> the remote host, thus we can't allow remote migration. All other forms
> of migration (e.g. saving to file) are okay though as they don't clash
> with semantics of the flag.
> 
> Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> ---
>  src/qemu/qemu_migration.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@xxxxxxxxxx>

> 
> diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
> index 3c45ba35e6..a98ec2d55a 100644
> --- a/src/qemu/qemu_migration.c
> +++ b/src/qemu/qemu_migration.c
> @@ -1155,7 +1155,8 @@ qemuMigrationSrcIsAllowed(virQEMUDriverPtr driver,
> 
>      /* following checks don't make sense for offline migration */
>      if (!(flags & VIR_MIGRATE_OFFLINE)) {
> -        if (qemuProcessAutoDestroyActive(driver, vm)) {
> +        if (remote &&
> +            qemuProcessAutoDestroyActive(driver, vm)) {
>              virReportError(VIR_ERR_OPERATION_INVALID,
>                             "%s", _("domain is marked for auto destroy"));
>              return false;
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux