Re: [PATCH 1/1] conf: handle empty string in interface target name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 23, 2019 at 11:21:33 -0300, Daniel Henrique Barboza wrote:
> 
> 
> On 9/23/19 8:55 AM, Nikolay Shirokovskiy wrote:
> > Empty name is not allowed by schema but qemu is able to start with such
> > a config (and I guess some other hypervisors too). As a result name will
> > be generated by kernel and have form 'tap<N>'. At the same time if
> > target element is ommited in config the name will be generated by
> > libvirt and have form 'vnet<N>'. Let's have only the latter pattern
> > for autogenerated names by treating empty name as ommited.
> > 
> > Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@xxxxxxxxxxxxx>
> > ---
> 
> Reviewed-by: Daniel Henrique Barboza <danielhb413@xxxxxxxxx>

Change like this usually requires a test XML addition so that we can
validate and prevent regressions.

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux