Re: [PATCHv2] maint: Use flake8 to check python code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 18, 2019 at 12:19:43PM +0800, Shi Lei wrote:
Replace 'sc_prohibit_semicolon_at_eol_in_python' with generic 'sc_flake8' rule
to check python code style.

Now 'sc_flake8' just check the error E703: 'statement ends with a semicolon'.
In future, we could use '--select' to introduce more rules.

Signed-off-by: Shi Lei <shi_lei@xxxxxxxxxxxxxx>
---

v1: https://www.redhat.com/archives/libvir-list/2019-September/msg00501.html
since v1:
- Use the return-value from flake8 directly for 'sc_flake8'.
- Add the option '--show-source' to be more helpful for developers.
- Set checking for 'flake8' as a soft requirement.


cfg.mk       | 17 ++++++++++++-----
configure.ac |  4 ++++
2 files changed, 16 insertions(+), 5 deletions(-)


Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

and pushed now

Jano

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux