Re: [PATCH 2/3] qemu: move runtime netdev validation into a separate function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/13/19 4:02 PM, Michal Prívozník wrote:
On 9/13/19 4:52 PM, Laine Stump wrote:


+            qemuCaps && !virQEMUCapsGet(qemuCaps, QEMU_CAPS_VHOSTUSER_MULTIQUEUE)) {

NULL is never passed to qemuCaps, so no need to check it.


I had put that in so I could also call it from qemuDomainDeviceDefValidateNetwork() (which doesn't have qemuCaps or even a domainObjPtr to get it from) and catch as many invalid configs as possible at parse time rather than runtime. But I wasn't happy with the patch to do that so I haven't sent it (and anyway it looks like I can just add qemuCaps to the args for that function), so I'll take it out before pushing.

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux