Stumbled on this while changing qemu_conf.c for other reasons. Moved code around here and there to avoid repetition. Final result is 23 less lines for the same functionality, which is nothing to write home about but seems okay to contribute. Daniel Henrique Barboza (3): qemu_conf.c: introduce qemuAddRemoveSharedHostdevInternal qemu_conf.c: introduce qemuAddRemoveSharedDiskInternal qemu_conf.c: introduce qemuAddRemoveSharedDeviceInternal src/qemu/qemu_conf.c | 193 +++++++++++++++++++------------------------ 1 file changed, 85 insertions(+), 108 deletions(-) -- 2.21.0 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list