Re: [PATCH 1/1] tools: rewrite virt-host-validate in Go to be data driven

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 03, 2019 at 08:56:14AM +0200, Peter Krempa wrote:
> On Mon, Sep 02, 2019 at 17:38:26 +0100, Daniel Berrange wrote:
> > The current virt-host-validate command has a bunch of checks
> > defined in the source code which are thus only extensible by
> > the upstream project, or downstream code modification.
> 
> [...]
> 
> This breaks in make check on my machine with no 'go' [1] installed:
> 
> make[1]: Entering directory '/home/pipo/build/libvirt/gcc/tools'
> make  check-am
> make[2]: Entering directory '/home/pipo/build/libvirt/gcc/tools'
> make  check-local
> make[3]: Entering directory '/home/pipo/build/libvirt/gcc/tools'
> cd /home/pipo/libvirt/tools/host-validate && no test  ./...
> /bin/sh: no: command not found
> make[3]: *** [Makefile:4039: check-local] Error 127

Opps, that should have been inside the WITH_HOST_VALIDATE conditional

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux