Re: [PATCH 2/3] tests: qemublock: Use bigger numbers as dummy capacity/physical

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 30, 2019 at 05:30:35PM +0200, Christophe de Dinechin wrote:

Peter Krempa writes:

Actually test that the full range is available.

[...]
         return -1;
diff --git a/tests/qemublocktestdata/imagecreate/luks-encopts.json b/tests/qemublocktestdata/imagecreate/luks-encopts.json
index f065ad89a7..c5ca863f5b 100644
--- a/tests/qemublocktestdata/imagecreate/luks-encopts.json
+++ b/tests/qemublocktestdata/imagecreate/luks-encopts.json
@@ -2,7 +2,7 @@ protocol:
 {
   "driver": "file",
   "filename": "/var/lib/libvirt/images/i.img",
-  "size": 42
+  "size": 4294967296
 }

Does any of these tests actually require that much space to run?

No, parsing a four hundred byte json file does not really take much
space.

Jano

If so, what is the impact on QE teams?

--
Cheers,
Christophe de Dinechin (IRC c3d)

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux