Re: [PATCH 0/2] [for-5.7.0] qemu: Honor qemu's request to use all vCPU props

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 29, 2019 at 03:45:15PM +0200, Peter Krempa wrote:
qemu documents that we should pass in all fields of
'CpuInstanceProperties' back when hotplugging cpus, but we didn't do
that. It turns out that qemu wanted to add new fields which were
mandatory and thus broke the interop with libvirt.

Let's honor their reques.


s/reques/request/

Peter Krempa (2):
 qemu: Extract and store vCPU properties as qemu returned them
 qemu: command: Use all vCPU properties when creating args for vCPU
   hotplug

src/qemu/qemu_command.c                       | 19 +++----------------
src/qemu/qemu_domain.c                        |  3 +++
src/qemu/qemu_domain.h                        |  3 +++
src/qemu/qemu_monitor.c                       |  2 ++
src/qemu/qemu_monitor.h                       |  6 ++++++
src/qemu/qemu_monitor_json.c                  |  4 ++++
.../x86-modern-bulk-monitor.json              |  8 ++++----
.../x86-modern-individual-add-monitor.json    |  4 ++--
8 files changed, 27 insertions(+), 22 deletions(-)


Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux