On Tue, Aug 27, 2019 at 16:22:02 +0200, Bjoern Walk wrote:
> Ján Tomko <jtomko@xxxxxxxxxx> [2019-08-27, 01:51PM +0200]:
> > On Tue, Aug 13, 2019 at 05:40:30PM +0200, Boris Fiuczynski wrote:
> > > diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
> > > index 6fa9a26b64..6f672184be 100644
> > > --- a/tests/qemuxml2xmltest.c
> > > +++ b/tests/qemuxml2xmltest.c
> > > @@ -958,6 +958,10 @@ mymain(void)
> > > QEMU_CAPS_CCW,
> > > QEMU_CAPS_CCW_CSSID_UNRESTRICTED,
> > > QEMU_CAPS_DEVICE_VFIO_CCW);
> > > + DO_TEST("hostdev-subsys-mdev-vfio-ccw-boot",
> > > + QEMU_CAPS_CCW,
> > > + QEMU_CAPS_CCW_CSSID_UNRESTRICTED,
> > > + QEMU_CAPS_DEVICE_VFIO_CCW);
> >
> > DO_TEST_CAPS_ARCH_LATEST
>
> Thanks for the review, much appreciated. v3 is sent.
>
> Out of curiosity and for future reference, the DO_TEST_*_LATEST macros
> are preferred for new tests now? Are the old test macros deprecated and
> should we convert older tests?
There are a handful of specific scenarios where the old macro might be
worth using, but generally, the _LATEST or _VER macros should be used
with actual real capabilities.
Converting the existing test cases to the new macros is obviously
welcome but nobody really works on in systematically. If you are willing
to convert any number of tests, it's obviously welcome.
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
