Re: [PATCH 5/9] virhostdevtest: Drop most of 'cleanup' and 'out' labels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 12, 2019 at 01:54:21PM +0200, Michal Privoznik wrote:
From: Michal Privoznik <miso.privoznik@xxxxxxxxx>


Different e-mail.

In this test there is this macro CHECK_LIST_COUNT() which checks
if a list of PCI devices contains expected count. If it doesn't
an error is reported and 'goto cleanup' is invoked. There's no
real reason for that as even since its introduction there is no
cleanup done and all 'cleanup' labels contains nothing but
'return'.

Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
---
tests/virhostdevtest.c | 147 ++++++++++++-----------------------------
1 file changed, 42 insertions(+), 105 deletions(-)


Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux