Re: [PATCH 10/11] tests: Avoid gnulib replacements in mocks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 21, 2019 at 07:13:22PM +0300, Roman Bolshakov wrote:
> gnulib headers change stat, lstat and open to replacement functions,
> even for function definitions. This effectively disables standard
> library overrides in virfilewrapper and virmockstathelpers since they
> are never reached.
> 
> Rename the functions and provide a declartion that uses correct
> assembler name for the mocks.
> 
> This fixes firmware lookup in domaincapstest on macOS.
> 
> Signed-off-by: Roman Bolshakov <r.bolshakov@xxxxxxxxx>
> ---
>  tests/virfilewrapper.c     |  5 +++++
>  tests/virmockstathelpers.c | 10 ++++++++++
>  2 files changed, 15 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux