Re: [PATCH 01/11] tests: Don't test octal localhost IP in sockettest on macOS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 21, 2019 at 07:13:13PM +0300, Roman Bolshakov wrote:
> getaddrinfo on macOS doesn't interpret octal IPv4 addresses. Only
> inet_aton can be used for that. Therefore, from macOS standpoint
> "0177.0.0.01" is not the same as "127.0.0.1".
> 
> The issue was also discovered by python and dotnet core:
>   https://bugs.python.org/issue27612
>   https://github.com/dotnet/corefx/issues/8362
> 
> Signed-off-by: Roman Bolshakov <r.bolshakov@xxxxxxxxx>
> ---
>  tests/sockettest.c | 4 ++++
>  1 file changed, 4 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux