Re: [PATCH 1/5] virUUIDFormat: s/VIR_UUID_RAW_LEN/VIR_UUID_BUFLEN/ in comment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 14, 2019 at 16:33:19 +0200, Michal Privoznik wrote:
> The function takes raw UUID and formats it into string
> representation. However, the comment mistakenly states that the
> expected size of raw UUID buffer is VIR_UUID_RAW_LEN bytes. We
> don't have such constant since v0.3.2~24. It should have been
> VIR_UUID_BUFLEN.
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  src/util/viruuid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/util/viruuid.c b/src/util/viruuid.c
> index 0c12ddcc3e..8930a0e199 100644
> --- a/src/util/viruuid.c
> +++ b/src/util/viruuid.c
> @@ -141,7 +141,7 @@ virUUIDParse(const char *uuidstr, unsigned char *uuid)
>  
>  /**
>   * virUUIDFormat:
> - * @uuid: array of VIR_UUID_RAW_LEN bytes to store the raw UUID
> + * @uuid: array of VIR_UUID_BUFLEN bytes to store the raw UUID
>   * @uuidstr: array of VIR_UUID_STRING_BUFLEN bytes to store the
>   * string representation of the UUID in. The resulting string
>   * will be NULL terminated.

Reviewed-by: Jiri Denemark <jdenemar@xxxxxxxxxx>

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux