On Thu, Nov 26, 2009 at 06:27:26PM +0000, Daniel P. Berrange wrote:
> * src/uml/uml_driver.c: Introduce umlDomainObjPrivateData for storing
> monitor device state. Remove unneccessary VIR_FREE on vcpupids
> ---
> src/uml/uml_driver.c | 58 +++++++++++++++++++++++++++++++++++++++----------
> 1 files changed, 46 insertions(+), 12 deletions(-)
[...]
> - if (vm->monitor != -1)
> - close(vm->monitor);
> - vm->monitor = -1;
> + if (priv->monitor != -1)
> + close(priv->monitor);
> + priv->monitor = -1;
Okay, it's never set by that driver.
> if ((ret = waitpid(vm->pid, NULL, 0)) != vm->pid) {
> VIR_WARN(_("Got unexpected pid %d != %d"),
> @@ -917,8 +953,6 @@ static void umlShutdownVMDaemon(virConnectPtr conn ATTRIBUTE_UNUSED,
> vm->pid = -1;
> vm->def->id = -1;
> vm->state = VIR_DOMAIN_SHUTOFF;
> - VIR_FREE(vm->vcpupids);
> - vm->nvcpupids = 0;
>
> umlCleanupTapDevices(conn, vm);
>
ACK
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list