On 8/13/19 10:49 AM, Jiri Denemark wrote: > Gnulib's make coverage (or init-coverage, build-coverage, gen-coverage) > is not a 1-1 replacement for the original configure option. Our old > --enable-test-coverage seems to be close to gnulib's make build-coverage > except gnulib runs lcov in that phase and the build actually fails for > me even before lcov is run. And since we want to be able to just build > libvirt without running lcov, I suggest reverting to our own > implementation. > > I admit the best solution would be to somehow make gnulib support what > we need (and fix the actual build), but I don't feel brave enough to do > that. Eric? :-) There, it's probably better to ask the bug-gnulib list (rather than just me), to possibly widen the set of developers that could actually make those sort of changes. > > Also if we ever switch to glib and drop gnulib completely, we would need > to reintroduce our own implementation anyway. True. > > I had to do some changes to resolve conflicts. The changes were not too > big, but I figured I'd rather resend this patch especially when I > originally forgot to Cc the original author of the reverted patch. > > Jiri Denemark (2): > Revert "configure: Remove --enable-test-coverage" > Revert "docs: hacking: Add 'Code coverage reports' section" > ACK series -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
