On Wed, 2019-08-07 at 10:30 +0200, Michal Privoznik wrote: > v2 of: > > https://www.redhat.com/archives/libvir-list/2019-July/msg01225.html > > diff to v1: > - Rebase and adapt to new checkpoint completer > > Michal Prívozník (15): > tools: s/Nodedev/NodeDevice/ > tools: Expose virshCommaStringListComplete() > tools: Separate domain related completers into a file > tools: Separate storage pool related completers into a file > tools: Separate storage volume related completers into a file > tools: Separate interface related completers into a file > tools: Separate network related completers into a file > tools: Separate nodedev related completers into a file > tools: Separate nwfilter related completers into a file > tools: Separate secret related completers into a file > tools: Separate snapshot related completers into a file > tools: Separate host related completers into a file > tools: Separate checkpoint related completers into a file > virsh-completer: Drop needless #include > virsh: Introduce virshPoolTypeCompleter > > tools/Makefile.am | 11 + > tools/virsh-completer-checkpoint.c | 78 +++ > tools/virsh-completer-checkpoint.h | 27 + > tools/virsh-completer-domain.c | 314 +++++++++ > tools/virsh-completer-domain.h | 55 ++ > tools/virsh-completer-host.c | 148 ++++ > tools/virsh-completer-host.h | 31 + > tools/virsh-completer-interface.c | 67 ++ > tools/virsh-completer-interface.h | 27 + > tools/virsh-completer-network.c | 145 ++++ > tools/virsh-completer-network.h | 35 + > tools/virsh-completer-nodedev.c | 117 ++++ > tools/virsh-completer-nodedev.h | 35 + > tools/virsh-completer-nwfilter.c | 105 +++ > tools/virsh-completer-nwfilter.h | 31 + > tools/virsh-completer-pool.c | 120 ++++ > tools/virsh-completer-pool.h | 35 + > tools/virsh-completer-secret.c | 91 +++ > tools/virsh-completer-secret.h | 31 + > tools/virsh-completer-snapshot.c | 73 ++ > tools/virsh-completer-snapshot.h | 27 + > tools/virsh-completer-volume.c | 73 ++ > tools/virsh-completer-volume.h | 28 + > tools/virsh-completer.c | 1028 +------------------------- > -- > tools/virsh-completer.h | 114 +-- > tools/virsh-nodedev.c | 16 +- > tools/virsh-nodedev.h | 6 +- > tools/virsh-pool.c | 1 + > 28 files changed, 1730 insertions(+), 1139 deletions(-) > create mode 100644 tools/virsh-completer-checkpoint.c > create mode 100644 tools/virsh-completer-checkpoint.h > create mode 100644 tools/virsh-completer-domain.c > create mode 100644 tools/virsh-completer-domain.h > create mode 100644 tools/virsh-completer-host.c > create mode 100644 tools/virsh-completer-host.h > create mode 100644 tools/virsh-completer-interface.c > create mode 100644 tools/virsh-completer-interface.h > create mode 100644 tools/virsh-completer-network.c > create mode 100644 tools/virsh-completer-network.h > create mode 100644 tools/virsh-completer-nodedev.c > create mode 100644 tools/virsh-completer-nodedev.h > create mode 100644 tools/virsh-completer-nwfilter.c > create mode 100644 tools/virsh-completer-nwfilter.h > create mode 100644 tools/virsh-completer-pool.c > create mode 100644 tools/virsh-completer-pool.h > create mode 100644 tools/virsh-completer-secret.c > create mode 100644 tools/virsh-completer-secret.h > create mode 100644 tools/virsh-completer-snapshot.c > create mode 100644 tools/virsh-completer-snapshot.h > create mode 100644 tools/virsh-completer-volume.c > create mode 100644 tools/virsh-completer-volume.h > Series looks good to me, though you may want to wait for somebody with more experience to properly ack it. Reviewed-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx> -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
