On Thu, Aug 08, 2019 at 05:33:40PM +0200, Andrea Bolognani wrote: > On Thu, 2019-08-08 at 16:10 +0100, Daniel P. Berrangé wrote: > > +++ b/src/remote/remote_daemon_dispatch.c > > @@ -2077,6 +2105,9 @@ remoteDispatchConnectOpen(virNetServerPtr server ATTRIBUTE_UNUSED, > > unsigned int flags; > > struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client); > > int rv = -1; > > +#ifdef MODULE_NAME > > + const char *type = NULL; > > +#endif /* !MODULE_NAME */ > > Nit: the comment should read > > /* ! MODULE_NAME */ I don't see any reason to change that here - with & without the space are both widely used across libvirt Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
