Re: [PATCH v4 15/42] build: don't hardcode /etc in the config related files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2019-08-08 at 16:10 +0100, Daniel P. Berrangé wrote:
> +++ b/src/remote/libvirtd.conf.in
>  # Use of TLS requires that x509 certificates be issued. The default locations
>  # for the certificate files is as follows:
>  #
> -#   /etc/pki/CA/cacert.pem                 - The CA master certificate
> -#   /etc/pki/libvirt/servercert.pem        - The server certificate signed with
> -#                                            the cacert.pem
> -#   /etc/pki/libvirt/private/serverkey.pem - The server private key
> +#   @sysconfdir@/pki/CA/cacert.pem - The CA master certificate
> +#   @sysconfdir@/pki/libvirt/servercert.pem - The server certificate signed with
> +#   the cacert.pem

Absolute nit: I'd leave the description in a single line, which will
then end up being shorter than 80 columns anyway in most cases, or at
least indent the second line by 4 or more spaces just to make sure
the path itself doesn't disappear in the noise.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux