On Mon, 2019-07-29 at 18:11 +0100, Daniel P. Berrangé wrote: > +++ b/src/util/viridentity.c > -int virIdentityGetUNIXUserName(virIdentityPtr ident, > - const char **username) > +int virIdentityGetOSUserName(virIdentityPtr ident, > + const char **username) Since you're touching all of these anyway, you might as well take the opportunity to move the return type to its own line. Assuming the parallel conversation about reusing VIR_CLIENT_INFO_* doesn't lead anywhere, Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx> -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list