On Mon, 2019-07-29 at 18:11 +0100, Daniel P. Berrangé wrote: > +++ b/src/remote/remote_driver.c > @@ -976,6 +977,29 @@ doRemoteOpen(virConnectPtr conn, > + switch ((remoteDriverTransport)transport) { > + case REMOTE_DRIVER_TRANSPORT_UNIX: > + case REMOTE_DRIVER_TRANSPORT_SSH: > + case REMOTE_DRIVER_TRANSPORT_LIBSSH: > + case REMOTE_DRIVER_TRANSPORT_LIBSSH2: > + if (!sockname && > + !(sockname = remoteGetUNIXSocket(transport, flags))) > + goto failed; Curly brackets around the body. Also you should have either a break statement (preferred) or an ATTRIBUTE_FALLTHROUGH annotation here. -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list