On Mon, Jul 29, 2019 at 12:25:08PM +0200, Andrea Bolognani wrote: > On Tue, 2019-07-23 at 17:03 +0100, Daniel P. Berrangé wrote: > [...] > > +++ b/src/remote/remote_daemon_dispatch.c > > +static int > > +remoteDispatchProbeURI(bool readonly, char **probeduri) > > Once again, there should be one argument per line and a personal > preference I'd rather have readonly as the last one, but you can > safely ignore the latter comment if you feel otherwise. probeduri is an output parameter, and by convention those should always be last. > [...] > > + /* Even if we didn't probe any socket, we won't > > + * return error. Just let virConnectOpen's normal > > + * logic run which will likely return an error anyway > > + */ > > I didn't verify this myself, but I hope that when you wrote "likely" > above what you really meant was "definitely", "certainly", > "absolutely", "without any doubt" or something along those lines ;) It could still fallback to open a stateless driver, so "likely" is correct. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
