Re: [PATCH 41/41] libvirt: correctly print out URI returned from probing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2019-07-29 at 14:34 +0200, Andrea Bolognani wrote:
> On Tue, 2019-07-23 at 17:03 +0100, Daniel P. Berrangé wrote:
> > Turning a NULL URI instead the empty string is very misleading when
> > reading the debug logs as the distinction between the two is
> > functionally important.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> > ---
> >  src/libvirt.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> This looks like it could have been waaay earlier in the series, or
> even pushed trivially outside of it... I guess you wanted to have a
> little treat for whoever made it to the end of the series! :)
> 
> Looking forward to v3!

And of course I forgot the most important bit:

  Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux